Use proper ID type for rest update method

feathersjs · Jul 19, 2023 · 4676d04 · 4676d04
1 parent ccc9370
commit 4676d04
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/rest-client/src/base.ts b/packages/rest-client/src/base.ts
@@ -139,7 +139,7 @@ export abstract class Base<T = any, D = Partial<T>, P extends Params = RestClien
     return this._create(data, params)
   }
 
-  _update(id: NullableId, data: D, params?: P) {
+  _update(id: Id, data: D, params?: P) {
     if (typeof id === 'undefined') {
       return Promise.reject(new Error("id for 'update' can not be undefined"))
     }
@@ -155,7 +155,7 @@ export abstract class Base<T = any, D = Partial<T>, P extends Params = RestClien
     ).catch(toError)
   }
 
-  update(id: NullableId, data: D, params?: P) {
+  update(id: Id, data: D, params?: P) {
     return this._update(id, data, params)
   }