fix(authentication-oauth): Allow POST oauth callbacks

feathersjs · Jun 4, 2024 · ebf3de1 · ebf3de1
1 parent c7b0111
commit ebf3de1
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/packages/authentication-oauth/src/index.ts b/packages/authentication-oauth/src/index.ts
@@ -3,7 +3,7 @@ import { createDebug } from '@feathersjs/commons'
 import { resolveDispatch } from '@feathersjs/schema'
 
 import { OAuthStrategy, OAuthProfile } from './strategy'
-import { redirectHook, OAuthService } from './service'
+import { redirectHook, OAuthService, OAuthCallbackService } from './service'
 import { getGrantConfig, authenticationServiceOptions, OauthSetupSettings } from './utils'
 
 const debug = createDebug('@feathersjs/authentication-oauth')
@@ -34,6 +34,7 @@ export const oauth =
     const grantConfig = getGrantConfig(authService)
     const serviceOptions = authenticationServiceOptions(authService, oauthOptions)
     const servicePath = `${grantConfig.defaults.prefix || 'oauth'}/:provider`
+    const callbackServicePath = `${servicePath}/callback`
 
     app.use(servicePath, new OAuthService(authService, oauthOptions), serviceOptions)
 
@@ -43,6 +44,12 @@ export const oauth =
       around: { all: [resolveDispatch(), redirectHook()] }
     })
 
+    app.use(
+      callbackServicePath,
+      new OAuthCallbackService(app.service(servicePath) as unknown as OAuthService),
+      serviceOptions
+    )
+
     if (typeof oauthService.publish === 'function') {
       app.service(servicePath).publish(() => null)
     }

diff --git a/packages/authentication-oauth/src/service.ts b/packages/authentication-oauth/src/service.ts
@@ -178,14 +178,26 @@ export class OAuthService {
   async get(override: string, params: OAuthParams) {
     const result = await this.handler('GET', params, {}, override)
 
-    if (override === 'callback') {
-      return this.authenticate(params, result)
-    }
-
     return result
   }
 
   async create(data: any, params: OAuthParams) {
     return this.handler('POST', params, data)
   }
 }
+
+export class OAuthCallbackService {
+  constructor(public service: OAuthService) {}
+
+  async find(params: OAuthParams) {
+    const result = await this.service.handler('GET', params, {}, 'callback')
+
+    return this.service.authenticate(params, result)
+  }
+
+  async create(data: any, params: OAuthParams) {
+    const result = await this.service.handler('POST', params, data, 'callback')
+
+    return this.service.authenticate(params, result)
+  }
+}