Merged
Conversation
FranciszekCzana
commented
Mar 16, 2025
Comment on lines
+122
to
-120
| case unknown | ||
| // @TODO: add Date type? | ||
| // @TODO: add `null` and `undefined` somehow |
Contributor
Author
There was a problem hiding this comment.
There is no undefined in JSON Object at all.
If anyone would like to add any, valid JSON object should have converted it to null
AMatecki
approved these changes
Mar 16, 2025
polok
reviewed
Mar 16, 2025
|
|
||
| func testShouldParseNilVariables() { | ||
|
|
||
| // GIVEN |
Contributor
There was a problem hiding this comment.
PascalCase -> "Given" to be consistent
Contributor
Author
There was a problem hiding this comment.
In this file all tests have upppercase. Maybe should I update them for consistency?
Rolfrider
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.