frontend: set the font-size to 16px #4058
Conversation
Pull Request validationFailed🔴 Review - Missing review from a member (2 required) Success🟢 CI - All checks have passed |
|
hi, any reason why? |
|
The default font size (9px?) is too small for me; it's difficult for me to read. Although I can zoom in, the page becomes cluttered when zoomed in. Larger fonts also look more aesthetically pleasing. |
|
Would you mind posting screenshots before and after the change, so it is obvious where is the difference; and we would let the community vote in the next month maybe?
I was asking the same question; answers to "why?" would be preferably directly in git commit message. |
|
before: after: |
|
Agreed that our font size is probably a bit too small. But I wouldn't go to 16px, that's too much. Good for prose, but IMHO too much for the information we are showing. I'd bump it to 14px max. But the second screenshot clearly shows that it won't be as easy as just increasing the number. We need to fix whatever page elements it breaks. |
|
what is about this: before: after: 
- html { font-size: 10px; }
- body { font-size: 12px; }
+ body { font-size: 0.875rem; }12px -> 14px |
|
I am -1 to use directly px. |
praiskup
left a comment
praiskup
left a comment
There was a problem hiding this comment.
Ok, it seems even smaller :-) reverting my approve.
|
|
||
| body { | ||
| background-color: #eee; | ||
| font-size: 0.875rem; |
There was a problem hiding this comment.
yep sorry for wanting so many contradicting changes for you :D I deployed your change to our staging instance (https://copr.stg.fedoraproject.org/coprs/) and it was even smaller :/ ... I tried to put here 1.4 and deploy it and it seems OK to me (again deployed https://copr.stg.fedoraproject.org/coprs/ so you can have a look) - is that font-size ok with you?
| font-size: 0.875rem; | |
| font-size: 1.4rem; |
There was a problem hiding this comment.
It seems to be covered by patternfly.min.css. If you disable this rule, 0.875rem looks fine.
There was a problem hiding this comment.
I added a new rule to force the font size of the html to 1rem.
Can you redeploy one to see the effect? I don't know how to preview locally
There was a problem hiding this comment.
for some reason this is still broken :/ https://copr.stg.fedoraproject.org/coprs/
… browser settings, while setting the body's font size to 0.875rem(about 14px) Signed-off-by: loongtao.zhang <[email protected]>
|
edit: wrong ticket |
5 participants
No description provided.