Skip to content

Conversation

@FrostyX
Copy link
Member

@FrostyX FrostyX commented Jan 16, 2026

And some TODOs that I am not sure how to address

Otherwise for example the -- characters get converted to one UTF symbol which
doesn't work in commandline.
@FrostyX FrostyX added the doc label Jan 16, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several small but useful improvements to the hotfix SOP documentation. The changes correctly fix the reStructuredText syntax for code blocks, update an external link to a more robust internal reference, and add important TODO notes about issues encountered during the process. My review includes a couple of minor suggestions to further improve clarity and correct a grammatical error in the documentation.

@github-actions
Copy link

Pull Request validation

Failed

🔴 Review - Missing review from a member (2 required)

Success

🟢 CI - All checks have passed

Run:
Run::

# TODO For some reason it doesn't report anything
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me? The cherry-picked commit should be reported at least.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today it reported for me as well. It's possible it was just some mistake on my side, so I dropped the TODO.

# Which is a problem because `tito release fedora-git` couldn't handle it
tito tag
# workarounded by
tito tag --use-version 1.1.hotfix.1 --use-release "1%{?dist}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember if @xsuchy explained the problem was caused by either the builder or tagger we set in 3ed9510 and therefore we can drop this documentation change or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants