-
Notifications
You must be signed in to change notification settings - Fork 80
Small improvements for the hotfix SOP #4126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Otherwise for example the -- characters get converted to one UTF symbol which doesn't work in commandline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several small but useful improvements to the hotfix SOP documentation. The changes correctly fix the reStructuredText syntax for code blocks, update an external link to a more robust internal reference, and add important TODO notes about issues encountered during the process. My review includes a couple of minor suggestions to further improve clarity and correct a grammatical error in the documentation.
Pull Request validationFailed🔴 Review - Missing review from a member (2 required) Success🟢 CI - All checks have passed |
doc/how_to_build_hotfix.rst
Outdated
| Run: | ||
| Run:: | ||
|
|
||
| # TODO For some reason it doesn't report anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked for me? The cherry-picked commit should be reported at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today it reported for me as well. It's possible it was just some mistake on my side, so I dropped the TODO.
| # Which is a problem because `tito release fedora-git` couldn't handle it | ||
| tito tag | ||
| # workarounded by | ||
| tito tag --use-version 1.1.hotfix.1 --use-release "1%{?dist}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And some TODOs that I am not sure how to address