Improve readability of chroots build graphs #4143
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the readability of the chroot build graphs by switching to a horizontal, sorted bar chart with dynamic height and distro-specific colors. The code is much cleaner and more effective at visualizing the data.
I have one suggestion to make the code more robust. Additionally, for future improvements, you might consider moving the osColors object and getColor function outside of chrootGraph to the module scope. Since they are constants, this would prevent them from being recreated on every function call, leading to better performance and code organization.
| if (!name) return osColors['alien']; | ||
| var lowerName = name.toLowerCase(); | ||
| for (var os in osColors) { | ||
| if (lowerName.indexOf(os) !== -1) return osColors[os]; |
There was a problem hiding this comment.
Iterating over an object with for...in can include inherited properties from the prototype chain. To make this loop more robust, it's best practice to check if the property belongs to the object itself using Object.prototype.hasOwnProperty.call().
| if (lowerName.indexOf(os) !== -1) return osColors[os]; | |
| if (Object.prototype.hasOwnProperty.call(osColors, os) && lowerName.indexOf(os) !== -1) return osColors[os]; |
Pull Request validationFailed🔴 Review - Missing review from a member (2 required) Success🟢 CI - All checks have passed |
1 participant
Fixes #3325