Skip to content

testing-farm: force pre-release copr-rpmbuild onto builder #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
praiskup wants to merge 4 commits into
base: main
Choose a base branch
from
Open

testing-farm: force pre-release copr-rpmbuild onto builder #4146

praiskup wants to merge 4 commits into from
+214 −16

Conversation

@praiskup
Copy link
Member

@praiskup praiskup commented Jan 30, 2026 •
edited by github-actions bot
Loading

Fixes: #4103

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 30, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces changes to dynamically fetch GitHub PR data and use it to install pre-release copr-rpmbuild packages in the testing-farm environment. While the overall approach is sound, there are a few areas for improvement. Specifically, there's redundant JSON parsing in an Ansible task, a logical error in how the COMMIT_SHA is constructed for package detection, a critical typo in a Jinja2 template, and an opportunity to improve the robustness of fetching the install-copr-packages script by referencing the PR's head SHA instead of the main branch. Addressing these points will enhance the correctness, efficiency, and maintainability of the solution.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

Pull Request validation

Failed

🔴 Review - Missing review from a member (2 required)

Success

🟢 CI - All checks have passed

@praiskup praiskup force-pushed the praiskup-test-pre-release-rpmbuild branch from da4772d to 17f8793 Compare January 30, 2026 14:39
@praiskup
Copy link
Member Author

praiskup commented Jan 30, 2026

/packit test

@praiskup praiskup force-pushed the praiskup-test-pre-release-rpmbuild branch from 17f8793 to d4467b2 Compare January 30, 2026 14:58
@praiskup
Copy link
Member Author

praiskup commented Jan 30, 2026

/packit test

@praiskup
Copy link
Member Author

praiskup commented Jan 30, 2026

/packit test

@praiskup praiskup force-pushed the praiskup-test-pre-release-rpmbuild branch from 121c327 to 125b50a Compare February 1, 2026 09:01
@praiskup
Copy link
Member Author

praiskup commented Feb 1, 2026

I added a new commit fixing generic test failure.

/packit test

@praiskup
beaker-tests: Temporarily build hello from F43
09f3137 
The `main` variant (Rawhide) uses a locally created `make dist` tarball,
to work-around the current FTBFS against the newest GCC:

https://src.fedoraproject.org/rpms/hello/c/af27df4609302190668b8db4cb85380aab4f7795?branch=rawhide

Waiting for a new GNU Hello release:

https://savannah.gnu.org/bugs/?67961
@praiskup praiskup force-pushed the praiskup-test-pre-release-rpmbuild branch from 125b50a to 09f3137 Compare February 1, 2026 14:16
@praiskup
Copy link
Member Author

praiskup commented Feb 1, 2026

/packit test

@praiskup praiskup force-pushed the praiskup-test-pre-release-rpmbuild branch from c0b08c2 to b872dcc Compare February 1, 2026 14:38
@praiskup
Copy link
Member Author

praiskup commented Feb 1, 2026

/packit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr/missing-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestingFarm: make sure pre-release copr-rpmbuild is used

1 participant

@praiskup