-
Notifications
You must be signed in to change notification settings - Fork 10
Announce fedora 42 and 43 riscv64 chroots #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @nikromen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new blog post announcing the official availability of Fedora RISC-V 64-bit (riscv64) build targets within the Copr ecosystem. This significant expansion adds support for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a blog post announcing the availability of Fedora 42 and 43 riscv64 chroots in Copr. The post is well-written and clearly communicates the important details, such as the use of QEMU emulation and its potential impact on build times. I have one suggestion to improve the user experience by providing a direct link for reporting issues.
| - **Expect longer build times** compared to native architectures | ||
| - **Not everything may work perfectly** — some packages might fail to build or behave unexpectedly due to emulation limitations | ||
|
|
||
| If you encounter any issues, please let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it easier for users to report problems, it would be helpful to provide a direct link to your issue tracker. This will guide users to the correct place to file bug reports or provide feedback.
| If you encounter any issues, please let us know! | |
| If you encounter any issues, please [let us know by opening an issue](https://github.com/fedora-copr/copr/issues)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like how Gemini changed the text, yours is better. But the link is a good idea.
| layout: post | ||
| --- | ||
|
|
||
| We are happy to announce that Fedora RISC-V 64-bit (riscv64) build targets are now available in Copr! The following chroots have been added to mock-core-configs and enabled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and enabled in Copr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also "have been added to mock-core-configs" could link to changelog
https://rpm-software-management.github.io/mock/Release-Notes-Configs-43.4
or at least mock-core-configs could link to
https://rpm-software-management.github.io/mock/Mock-Core-Configs
| We currently **do not have native RISC-V hardware** in our infrastructure. All riscv64 builds are performed using QEMU emulation on x86_64 machines. Because of this: | ||
|
|
||
| - **Expect longer build times** compared to native architectures | ||
| - **Not everything may work perfectly** — some packages might fail to build or behave unexpectedly due to emulation limitations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of the last bullet, put there:
- only userspace calls are possible. If your package needs to make a kernelspace call during the build time or the check phase, then your build will fail. Only a few packages are limited by this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop all the bold fonts in this paragraph. The text is very short, IMHO no need for the half of it to be screaming :-)
No description provided.