Production overrides for environment variables #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpodivin
reviewed
Apr 3, 2025
Collaborator
jpodivin
left a comment
jpodivin
left a comment
There was a problem hiding this comment.
Why not use these as defaults and allow for overrides from .env using interpolation?
https://docs.docker.com/compose/how-tos/environment-variables/variable-interpolation/
My original idea was to move all defaults out of the .env file and then removing it from git repository, allowing everybody to create only a minimal .env file with changed variables for their system. It's not that easy because many of the variables are used by the inference container. For the time being, let's just override production variables like this, so that we can avoid modifying and having changes in the .env file directly in production. Once we get rid of the inference container, it may be easier to revisit this topic.
jpodivin
approved these changes
Jun 9, 2025
Collaborator
|
Is this still cooking, or should we merge it? It looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original idea was to move all defaults out of the .env file and then removing it from git repository, allowing everybody to create only a minimal .env file with changed variables for their system. It's not that easy because many of the variables are used by the inference container.
For the time being, let's just override production variables like this, so that we can avoid modifying and having changes in the .env file directly in production.
Once we get rid of the inference container, it may be easier to revisit this topic.