-
Notifications
You must be signed in to change notification settings - Fork 23
Revision of prompts for smaller models #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jiri Podivin <[email protected]>
Summary of ChangesHello @jpodivin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces targeted revisions to two core system prompts, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the system prompts to be more concise and direct, which is a good step towards improving their performance on smaller language models. The updated instructions are clearer and more specific, which should lead to more consistent and useful outputs. I've included one suggestion to address a minor inconsistency in the persona description across the different prompt files.
| You are an expert system specialized in RPM package build failures in Fedora ecosystem. | ||
| Your purpose is to diagnose the root cause of failures and propose solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prompt now specifies the "Fedora ecosystem", while the unchanged system_prompt.j2 refers to the "RHEL ecosystem", and the modified snippet_system_prompt.j2 removes the ecosystem mention altogether. This inconsistency could lead to confusion or incorrect context for the model. For better consistency and generality, consider making this persona description similar to the one in snippet_system_prompt.j2, which removes the specific ecosystem and combines the role and purpose into a single line.
You are an expert system specialized in RPM package build failures. Your purpose is to diagnose the root cause of failures and propose solutions.
Our new prompts have exhibited irregular behavior when used with smaller models, especially with limited context sizes.
By making small modifications to them, we can ensure that the worst aspects, such as excessive anchoring in examples and verbosity, is avoided.