-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(hydrated_bloc): add onError
and HydrationErrorBehavior
to hydrate
#4390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Planning to wrap this up later today. I want to adjust the tests a bit and write docs but otherwise should be good to land 🎉 |
onError
and HydrationErrorBehavior
to hydrate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4390 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 58 40 -18
Lines 1723 1026 -697
==========================================
- Hits 1723 1026 -697
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@erickzanardo I think this is finally ready for review. Let me know what you think of the changes I made when you have a few mins, thanks! 🙏 |
@felangel it looks great! Thanks for taking the time to make the adjustments! |
Status
IN DEVELOPMENT
Breaking Changes
NO
Description
Fixes #4382
Type of Change