Skip to content

feat(hydrated_bloc): add onError and HydrationErrorBehavior to hydrate #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 14, 2025

Conversation

erickzanardo
Copy link
Contributor

Status

IN DEVELOPMENT

Breaking Changes

NO

Description

Fixes #4382

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel
Copy link
Owner

Planning to wrap this up later today. I want to adjust the tests a bit and write docs but otherwise should be good to land 🎉

@felangel felangel added enhancement New feature or request pkg:hydrated_bloc This issue is related to the hydrated_bloc package labels Jun 30, 2025
@felangel felangel changed the title feat: Adding onHydrationError to control the behavior of a failed hydration feat(hydrated_bloc): add onError and HydrationErrorBehavior to hydrate Jul 8, 2025
@felangel felangel marked this pull request as ready for review July 8, 2025 04:15
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8f911ce) to head (799f9a0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #4390    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           58        40    -18     
  Lines         1723      1026   -697     
==========================================
- Hits          1723      1026   -697     
Flag Coverage Δ
bloc_lint ?
hydrated_bloc 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felangel
Copy link
Owner

felangel commented Jul 8, 2025

@erickzanardo I think this is finally ready for review. Let me know what you think of the changes I made when you have a few mins, thanks! 🙏

@erickzanardo
Copy link
Contributor Author

@felangel it looks great! Thanks for taking the time to make the adjustments!

@felangel felangel merged commit bdd9d5d into felangel:master Jul 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:hydrated_bloc This issue is related to the hydrated_bloc package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Hydrated bloc looses stored state when error on fromJson
2 participants