Skip to content

docs(hydrated_bloc): improve storagePrefix documentation #4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025

Conversation

JakesMD
Copy link
Contributor

@JakesMD JakesMD commented Jul 8, 2025

Status

READY

Breaking Changes

NO

Description

Currently, the default behavior of storagePrefix relies on the runtimeType. Overriding it is critically important for web applications. When the code structure changes, the minified runtimeType will change, leading to loss of state (see #4335 for more details).

Despite its importance, many developers are unaware of storagePrefix and its potential impact on data persistence.

Proposed Changes

  • Update the documentation comment.
  • Add a dedicated section to the README providing a more prominent explanation of storagePrefix.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@JakesMD JakesMD requested a review from felangel as a code owner July 8, 2025 10:37
@felangel felangel added documentation Documentation requested pkg:hydrated_bloc This issue is related to the hydrated_bloc package labels Jul 14, 2025
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JakesMD thanks so much for the contribution! I left a bunch of small comments -- lmk what you think about my suggestions and I'll get these changes merged, thanks!

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bdd9d5d) to head (6b11e87).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4559   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         1733      1733           
=========================================
  Hits          1733      1733           
Flag Coverage Δ
hydrated_bloc 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JakesMD
Copy link
Contributor Author

JakesMD commented Jul 14, 2025

LGTM 👍

Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the contributions! ✅

@felangel felangel enabled auto-merge (squash) July 14, 2025 19:52
@felangel felangel merged commit ecebe86 into felangel:master Jul 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation requested pkg:hydrated_bloc This issue is related to the hydrated_bloc package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants