-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs(hydrated_bloc): improve storagePrefix
documentation
#4559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JakesMD thanks so much for the contribution! I left a bunch of small comments -- lmk what you think about my suggestions and I'll get these changes merged, thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 1733 1733
=========================================
Hits 1733 1733
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Felix Angelov <[email protected]>
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks so much for the contributions! ✅
Status
READY
Breaking Changes
NO
Description
Currently, the default behavior of
storagePrefix
relies on theruntimeType
. Overriding it is critically important forweb
applications. When the code structure changes, the minifiedruntimeType
will change, leading to loss of state (see #4335 for more details).Despite its importance, many developers are unaware of
storagePrefix
and its potential impact on data persistence.Proposed Changes
storagePrefix
.Type of Change