-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] fix: support different query parameter encoding #1654
base: main
Are you sure you want to change the base?
Conversation
🌿 Preview your docs: https://fern-preview-5023476d-d119-425e-ba02-26b6c54959f5.docs.buildwithfern.com |
Playwright test resultsDetails 1 test across 1 suite |
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Playwright test resultsDetails 100 tests across 9 suites Flaky testschromium › forward-proxy/nextjs.spec.ts › capture the flag Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
@@ -65,6 +65,12 @@ types: | |||
properties: | |||
key: string | |||
type: type.TypeReference | |||
arrayEncoding: optional<QueryParameterArrayEncoding> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mark this as default: comma? or do we treat everything as basic for now?
deepObject: | ||
type: type.ObjectProperty | ||
docs: A query parameter that is an object with properties and serialized as `a[key1]=value1` | ||
basic: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we
- fall back to comma-separated if basic is an array?
- fall back to deep object if basic is an object, or an array with objects?
🌿 Preview your docs: https://fern-preview-f96ce90b-403b-4456-8219-1694cbbff222.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-26fb8f92-dd07-4589-9e13-532a3942ff4e.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-60b3e1ba-dc68-4655-a7d9-53bd8d26bb1a.docs.buildwithfern.com |
Fixes FER-
Short description of the changes made
What was the motivation & context behind this PR?
How has this PR been tested?