Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] fix: support different query parameter encoding #1654

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dsinghvi
Copy link
Member

Fixes FER-

Short description of the changes made

What was the motivation & context behind this PR?

How has this PR been tested?

Copy link

Copy link

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9.1 seconds
commit  63e0035

Copy link

github-actions bot commented Oct 11, 2024

PR Preview

Copy link

github-actions bot commented Oct 11, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Oct 11, 2024

Playwright test results

passed  96 passed
flaky  1 flaky
skipped  3 skipped

Details

stats  100 tests across 9 suites
duration  1 minute, 36 seconds
commit  e5c3f1c

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@@ -65,6 +65,12 @@ types:
properties:
key: string
type: type.TypeReference
arrayEncoding: optional<QueryParameterArrayEncoding>
Copy link
Contributor

@abvthecity abvthecity Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark this as default: comma? or do we treat everything as basic for now?

deepObject:
type: type.ObjectProperty
docs: A query parameter that is an object with properties and serialized as `a[key1]=value1`
basic:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we

  • fall back to comma-separated if basic is an array?
  • fall back to deep object if basic is an object, or an array with objects?

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants