Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: limit enum splaying #2039

Merged
merged 4 commits into from
Jan 21, 2025
Merged

chore: limit enum splaying #2039

merged 4 commits into from
Jan 21, 2025

Conversation

RohinBhargava
Copy link
Member

@RohinBhargava RohinBhargava commented Jan 17, 2025 •
edited
Loading

Short description of the changes made

  • fixes an issue where very long enums were overflowing in allowed container
  • The logic is if the sum of the lengths of all of the enum variants is less than 20 characters, we render the "or"s. If not, we fall back to "enum"

What was the motivation & context behind this PR?

  • UI improvement

How has this PR been tested?

Screenshot 2025-01-17 at 3 53 09 PM Screenshot 2025-01-17 at 3 55 39 PM

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 17, 2025 9:02pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 17, 2025 9:02pm

@RohinBhargava RohinBhargava changed the title limit enum splaying chore: limit enum splaying Jan 17, 2025
@RohinBhargava RohinBhargava had a problem deploying to Preview - app.buildwithfern.com January 17, 2025 21:02 — with GitHub Actions Error
@RohinBhargava RohinBhargava had a problem deploying to Preview - app-dev.buildwithfern.com January 17, 2025 21:02 — with GitHub Actions Error
@RohinBhargava RohinBhargava marked this pull request as ready for review January 17, 2025 21:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

PR Preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Playwright test results

passed  99 passed
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  58.4 seconds
commit  973e5a3

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@RohinBhargava RohinBhargava enabled auto-merge (squash) January 21, 2025 16:16
@RohinBhargava RohinBhargava merged commit 4f8c634 into main Jan 21, 2025
16 of 17 checks passed
@RohinBhargava RohinBhargava deleted the rohin/limit-enum-splaying branch January 21, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abvthecity abvthecity abvthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RohinBhargava @abvthecity @fern-support