Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fdr): public s3 file uploads go through cloudfront #2042

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

dsinghvi
Copy link
Member

Short description of the changes made

Public S3 file uploads go through CDN.

What was the motivation & context behind this PR?

Performance when connecting from other regions (i.e. github actions).

How has this PR been tested?

Will be tested on dev

@dsinghvi dsinghvi marked this pull request as ready for review January 19, 2025 21:13
Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 19, 2025 9:13pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 19, 2025 9:13pm

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@dsinghvi dsinghvi merged commit 2db3182 into main Jan 19, 2025
15 of 17 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/s3-upload-urls-go-through-cloudfront branch January 19, 2025 21:17
Copy link

PR Preview

Copy link

Playwright test results

passed  98 passed
flaky  1 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 28 seconds
commit  491fdd2

Flaky tests

chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.mavenagi.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant