refactor: hide filesv2 from static props #2044
Open
+574
−334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
abvthecity
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
abvthecity
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
abvthecity
commented
Jan 21, 2025
| // "light" in logo && | ||
| // "dark" in logo && | ||
| // isFileIdOrUrl(logo.light) && | ||
| // isFileIdOrUrl(logo.dark) |
There was a problem hiding this comment.
still working on a new home for this logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to support S3'ifying all markdown files, we need to remove
filesV2from being streamed to the frontend.before this pr, the files record is passed to the client-side and injected at runtime. after this pr, the files record is used to resolve file references on the server side.
this PR affects:
Embedfeat: support local embeds #2024)