Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable edit of environments on double click #2465

Merged
merged 7 commits into from
Mar 31, 2025
Merged

fix: enable edit of environments on double click #2465

merged 7 commits into from
Mar 31, 2025
+75 −67

Conversation

chdeskur
Copy link
Contributor

@chdeskur chdeskur commented Mar 28, 2025 •
edited
Loading

this pr does three things

  • ensures the environment is always able to be edited by double clicking
  • restructures the HTML not to nest two buttons within each other
  • fixes broken tooltips within the API explorer

@chdeskur chdeskur requested a review from abvthecity as a code owner March 28, 2025 01:58
@vercel Vercel
Copy link

vercel bot commented Mar 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dev.ferndocs.com ✅ Ready (Inspect) Visit Preview Mar 29, 2025 2:40am
prod.ferndocs.com ✅ Ready (Inspect) Visit Preview Mar 29, 2025 2:40am
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-dashboard ⬜️ Skipped (Inspect) Mar 29, 2025 2:40am

@vercel vercel bot temporarily deployed to Preview – fern-dashboard March 28, 2025 15:18 Inactive
@chdeskur
Copy link
Contributor Author

Screen.Recording.2025-03-28.at.12.40.43.PM.mov

@kgowru kgowru self-requested a review March 28, 2025 17:25
kgowru
kgowru requested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@kgowru kgowru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you decrease the border-radius around the URL tag in API explorer a few clicks? Currently looks like a pill.

@vercel vercel bot temporarily deployed to Preview – fern-dashboard March 28, 2025 17:36 Inactive
@vercel vercel bot temporarily deployed to Preview – fern-dashboard March 28, 2025 17:48 Inactive
@chdeskur
Copy link
Contributor Author

Screenshot 2025-03-28 at 1 47 09 PM

@vercel vercel bot temporarily deployed to Preview – fern-dashboard March 29, 2025 02:24 Inactive
@vercel vercel bot temporarily deployed to Preview – fern-dashboard March 29, 2025 02:36 Inactive
@chdeskur chdeskur enabled auto-merge (squash) March 29, 2025 02:40
kgowru
kgowru approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@kgowru kgowru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chdeskur chdeskur merged commit a5bd4ae into app Mar 31, 2025
10 of 11 checks passed
@chdeskur chdeskur deleted the cd/environment-edit branch March 31, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgowru kgowru kgowru approved these changes

@dsinghvi dsinghvi dsinghvi approved these changes

@abvthecity abvthecity Awaiting requested review from abvthecity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chdeskur @kgowru @dsinghvi