Skip to content

feat: use propertyAccess for conditional rendering of request/response bodies #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sahil485 wants to merge 6 commits into from
Closed

feat: use propertyAccess for conditional rendering of request/response bodies #2717

sahil485 wants to merge 6 commits into from

Conversation

@sahil485
Copy link
Contributor

@sahil485 sahil485 commented May 10, 2025 •
edited by fern-support
Loading

Short description of the changes made

  • filter object properties in request/response bodies based on READ_ONLY/WRITE_ONLY property access
  • change a few components to client side rendering to filter properties/prevent redundant filtering

What was the motivation & context behind this PR?

  • customer specs with readOnly/writeOnly

How has this PR been tested?

  • manual testing, local test repos

@vercel
Copy link
Contributor

vercel bot commented May 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dev.ferndocs.com ✅ Ready (Inspect) Visit Preview May 22, 2025 11:04pm
fern-dashboard ✅ Ready (Inspect) Visit Preview May 22, 2025 11:04pm
fern-dashboard-dev ✅ Ready (Inspect) Visit Preview May 22, 2025 11:04pm
preview.ferndocs.com ✅ Ready (Inspect) Visit Preview May 22, 2025 11:04pm
prod-assets.ferndocs.com ✅ Ready (Inspect) Visit Preview May 22, 2025 11:04pm
prod.ferndocs.com ✅ Ready (Inspect) Visit Preview May 22, 2025 11:04pm

@sahil485 sahil485 marked this pull request as ready for review May 10, 2025 17:25
@sahil485 sahil485 requested a review from dsinghvi as a code owner May 10, 2025 17:25
@sahil485 sahil485 changed the title feat: Add propertyAccess and use it for conditional rendering DO NOT MERGE feat: Add propertyAccess and use it for conditional rendering May 12, 2025
@sahil485 sahil485 closed this May 14, 2025
@sahil485 sahil485 reopened this May 14, 2025
@fern-support fern-support changed the title DO NOT MERGE feat: Add propertyAccess and use it for conditional rendering feat: use propertyAccess for conditional rendering of request/response bodies May 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

This PR is stale because it has been open 25 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@davidkonigsberg davidkonigsberg added the Stale This PR hasn't has any commits or comments in 25 days or more. label Jun 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

This PR was closed because it has been inactive for 5 days after being marked stale.

@github-actions github-actions bot closed this Jun 30, 2025
@github-actions github-actions bot deleted the schatiwala/use-readonly-writeonly branch November 20, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsinghvi dsinghvi Awaiting requested review from dsinghvi

Assignees

No one assigned

Labels

Stale This PR hasn't has any commits or comments in 25 days or more.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sahil485 @davidkonigsberg