Skip to content

Conversation

@kafkas
Copy link
Member

@kafkas kafkas commented Jan 10, 2026

Description

Linear ticket: FER-8170

Fixes multiple issues that caused Python wire tests and snippets to be invalid or fail at runtime. It improves wire test setup and makes snippet/request encoding resilient to omitted/missing example values. Together, these changes unblock generating and running wire tests across a wider variety of SDK configurations.

Changes Made

  • Handle the Ellipsis OMIT sentinel in JSON encoding to prevent 'ellipsis' object is not iterable errors and avoid serializing omitted values.
  • Respect inline_request_params in snippet generation so request bodies can be passed correctly without unexpected keyword args.
  • Fix undiscriminated union snippet mapping by skipping nop() instantiations when selecting a matching union member.
  • Prefer OK examples / avoid asserting error paths when stubs aren’t generated to prevent false failures like “DID NOT RAISE ApiError”.
  • Synthesize placeholder values for required multipart file fields when examples omit them so file-upload endpoints don’t fail with missing required args.

Testing

  • Unit tests added/updated
  • Manual testing completed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI
  • Postman

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants