Add "transient" hint for notification #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that adding this flag make sense. For example when using xfce4-notifyd and enabled logging, every change of volume is stored in history, but if notification is marked as transient, then it's skipped in log.
Riesi
pushed a commit
to Riesi/pa-applet-revamp
that referenced
this pull request
Aug 6, 2018
… notify text Changed the right click display to sinks instead of options of the default sink. This allows for quickly selecting a new default sink. Maybe a bit dirty for now, but it works quite well. Fixed Notification only displaying pa-applet Changed deprecated function notify_notification_set_hint_int32 to notify_notification_set_hint Changed Notification info output Removed textual description of volume intensity added transient flag from Pull-request: fernandotcl#18 Added some TODO markers for finding the deprecated funktions for later modification maybe Write some additional infos into the README
|
Is this addressed by #18? If so, I'd rather merge that. |
|
Yes, this commit contains changes from this PR. |
|
Hi, what prevents this PR from being merged? |
|
Lack of time and interest in the project, sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that adding this flag make sense. For example when using xfce4-notifyd and enabled logging, every change of volume is stored in history, but if notification is marked as transient, then it's skipped in log.