-
-
Notifications
You must be signed in to change notification settings - Fork 149
Include libadwaita and other dependencies in the app bundle on macOS #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include libadwaita and other dependencies in the app bundle on macOS #271
Conversation
a1d3c7b to
832ce91
Compare
|
Not sure what's up with that Linux failure, I didn't change any of the application code. Maybe it's using some newer version of Rust with more warnings enabled? |
It seems like there are some new clippy lints in the newest version. I will fix that real quick |
|
You can rebase now ;) |
b41aa8e to
f59f91d
Compare
|
There we go, it's passing now |
|
Whats your status on this PR? |
|
Just fixing a minor permissions thing and it's good to go if you want it :)
|
|
Awesome! I will see if I can setup a vm again to at least test it myself once. It's kind of a pain on non-macos. |
|
Hey, I wanted to try out |
|
Note: I get the following build error when running the tagged release workflow from @mrled's branch. |
|
I fixed it in mrled#1. I also bumped the macos build platform to |
b756195 to
cd476e1
Compare
Remove need for recent bash altogether
cd476e1 to
0d1e07c
Compare
|
@apoorvkh I just cherry-picked this commit from your PR. I'm going to update the macos runner to macos-26 later on. Thank you! |
|
@mrled Thank you for the update! And sorry it took this long ... |
Copy all the requisite homebrew libraries, including libadwaita, into the macOS bundle. This makes it a standalone app that can be executed directly on any system without installing Homebrew and libadwaita first. Also does away with the requirement that Homebrew is installed to the default location, which is otherwise required because the binary refers to dynamic libraries via their absolute paths.