fix inconsistent mouse capture on macos #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that takes care of the mouse movement, can confirm it's consistent now |
feschber
force-pushed
the
improve-macos-capture
branch
from
96dd1a8 to
7730f3b
Compare
|
@NeoTheFox can you tell if it is slower than it should be? |
|
It feels slower, so I disabled mouse acceleration in sway (accel_profile "flat"), and now it feels 1:1. So it is consistent with the raw input, but now it has more to do with #156 |
On sway, the unaccelerated input is captured. So if this feels 1:1 to you that should be correct. At some point, I think I may somehow want to implemen a roundtrip test, as in emulate input and capture it to see if it matches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#343 this should improve things.
FYI @NeoTheFox (#339)