-
-
Notifications
You must be signed in to change notification settings - Fork 149
Implemented mouse config #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There is one more thing: Since we are making changes to the configuration, we should think about the names a bit more. # transformations applied to input events received from other devices
[event_post_processing]
mouse_sensitivity = 1.0
invert_scroll = trueThis would later enable a similar section for event pre transformations (when being sent to other devices): # transformations applied to input events sent to other devices
[event_pre_processing]
mouse_sensitivity = 1.0
# linear_acceleration_factor = 1.2
# scroll_sensitivity = 0.3
invert_scroll = falseMaybe you can come up with some better names, but I find |
|
Maybe |
|
Wouldn't a simple |
|
Not if we want to add pre processing later on |
|
That's fair. Done and done. |
|
A note on my formatter - my cargo version is |
I have the same version and it did complain about the formatting when running cargo fmt --check. Would you mind opening a separate PR for the rust-fmt.toml (I'm not against that) |
5497c68 to
c047a51
Compare
|
Ah one last thing: The |
|
Oh (in case you are unaware): The dynamic updates to the sensitivity and scrolling inversion do not work. You are passing the values to the EmulationProxy but not from there to the actual input-emulation. |
|
If you don't want to do it, I can fix it myself as well. |
|
I'll probably only be able to get back to this on the weekends, so if it's a quick fix - up to you. I'll do it myself in a few days otherwise |
Add two options:
mouse_mod - sets a linear acceleration for the emulated mouse
invert_scroll - inverts the scrolling direction for the emulated mouse
Hopefully it helps to make the pointer more consistent across multiple devices.
Previously discussed in #339