Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gen_smtp version to address Rebar 2 deprecation warning #205

Merged
merged 15 commits into from
Jun 15, 2022
Merged

Bump gen_smtp version to address Rebar 2 deprecation warning #205

merged 15 commits into from
Jun 15, 2022

Conversation

kyleboe
Copy link
Contributor

@kyleboe kyleboe commented Apr 19, 2022

Elixir 1.13 shows a deprecation warning for Rebar 2 which was a dependency of hut, a dependency of gen_smtp < 1.2.0.

dependency :hut is using Rebar 2, which is no longer maintained and no longer works in recent Erlang/OTP versions. Remove the :manager option or set it to :rebar3 instead

Bumping to gen_smtp ~> 1.2.0 removes the dependency on hut

@kyleboe kyleboe mentioned this pull request Apr 26, 2022
Closed
@kyleboe
Copy link
Contributor Author

kyleboe commented Apr 26, 2022

Resolves #206

@kyleboe
Copy link
Contributor Author

kyleboe commented Apr 26, 2022

@tgautier thoughts on how to support something like this?

It seems like there are issues with backwards compatibility. Not sure if it should be handled in a major version (or pre-release thereof) or if I'm just missing something in the CI pipelines.

@deepankar-j deepankar-j mentioned this pull request May 16, 2022
Closed
@deepankar-j
Copy link

This PR will also address Issue #192.

@kyleboe
Copy link
Contributor Author

kyleboe commented May 17, 2022

@tgautier Bump. Would appreciate your input on this. Thanks!

@jbcden
Copy link
Contributor

jbcden commented May 20, 2022

@tgautier Bump. Would appreciate your input on this. Thanks!

No idea if this would work but does restricting the version of ranch to 2.0.0 do it? I can't get erlang 20.3 to install locally at the moment but it shows up in the error messages so maybe it's worth a try? Sorry if you've already tried that 😓

@kyleboe
Copy link
Contributor Author

kyleboe commented Jun 6, 2022

Ok I was able to get tests to all pass locally on elixir 1.8.2 and OTP 22 by locking the ranch version to 2.0.0 as suggested above (thanks @jbcden!). Apologies for my slow response on this.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jun 8, 2022

Dang. Looks like there were issues on OTP < 21. Thoughts on dropping support for it? Or maybe adding a deprecation warning of some kind? Or maybe cutting a new major version?

@kyleboe
Copy link
Contributor Author

kyleboe commented Jun 8, 2022

Or another alternative would be dropping the --warnings-as-errors flag from the mix compile in the specs? There are some errors that seem fairly isolated to older versions of elixir/otp/deps

@jbcden
Copy link
Contributor

jbcden commented Jun 8, 2022

Dang. Looks like there were issues on OTP < 21. Thoughts on dropping support for it? Or maybe adding a deprecation warning of some kind? Or maybe cutting a new major version?

@kyleboe it looks like it might be better to drop. It looks like gen_smtp defines its minimum OTP version as 21: https://github.com/gen-smtp/gen_smtp/blob/master/rebar.config#L2.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jun 10, 2022

Removed OTP < 21 support and bumped to latest versions of OTP in the bamboo_smtp.yml matrix.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jun 10, 2022

I finally stopped being a doofus and just ran GH actions on my fork of the repo and got everything passing! https://github.com/kyleboe/bamboo_smtp/actions/runs/2477937365

@kyleboe
Copy link
Contributor Author

kyleboe commented Jun 14, 2022

Anyone from the maintainers have a chance to review and trigger CI? @babariviere possibly?

@babariviere
Copy link
Contributor

babariviere commented Jun 14, 2022 •
edited
Loading

Anyone from the maintainers have a chance to review and trigger CI? @babariviere possibly?

Hello, I am no longer part of the organization so I won't be able to merge it! Sorry for that.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jun 14, 2022

Ah Sorry to bother you.

@tgautier looks to be responsible for the most recent PR merge. Could you help with review/merge?

@tgautier tgautier merged commit 5a7fe64 into fewlinesco:develop Jun 15, 2022
@tgautier tgautier mentioned this pull request Jun 15, 2022
Merged
tgautier added a commit that referenced this pull request Jun 15, 2022
@tgautier
Release 4.2.0 (#207)
68115ee 
- Drop testing for OTP ~> 20.3 to align with [gen_smtp minimum otp version of 21](https://github.com/gen-smtp/gen_smtp/blob/99fad81cc3aeb33657ff7598c846c4120c3a480e/rebar.config#L2) ([#205])
- Bump elixir to 1.13.4 and erlang to 24.3.4 ([#205])
- Use `Enum.map_join/3` instead of `Enum.map/2 |> Enum.join/2`  ([#205])
- Dependencies update ([#205]):
  - core:
    - gen_smtp, ~> 1.2.0
  - dev/test:
    - credo, ~> 1.6.1

[#205]: #205
@adamu
Copy link

adamu commented Jun 15, 2022

Unfortunately the pin to ranch 2.0.0 makes this conflict with the latest (2.9.0) version of cowboy, which requires 1.8.0. gen_smtp specifies >= 1.8.0 FWIW.

@jbcden jbcden mentioned this pull request Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgautier tgautier tgautier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kyleboe @deepankar-j @jbcden @babariviere @adamu @tgautier