Port to new style signal slot syntax #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
force-pushed
the
new-style-connect
branch
from
a640c37
to
c65b18a
Compare
|
Thanks for the contribution. Modern code is better code :) I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://wiki.qt.io/New_Signal_Slot_Syntax.
There are still a few places that use the old syntax that I was planning to leave for a future PR. They are:
common/utils/standardaction.cpp: This forwards some slots as aconst char *and requires some more refactoring to make it work with the new style.common/utils/zoomaction.cpp: There's adisconnectin there that isn't ported because I couldn't make it work when compiled with KF5. The signal is deprecated and it doesn't like something..disconnectdoesn't work for lambas!app/mainwindow.cpp: The new syntax is confused byTikzEditorViewAbstractnot having acontentsChangedsignal. This also seems like it requires some refactoring.Otherwise, the porting is pretty straightforward. Some places are a bit less pretty because the new syntax requires explicit casting for overloaded functions, but it's not too bad.