(very WIP) KF6 port #78
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, I haven't had time to continue working on this after the general cleanups from a while back. My next item on the TODO list was porting to I'm also not sure if it's desired to keep the codebase working on both Qt5 and Qt6 (before it was working on both Qt4 and Qt5). It definitely requires some discussion and planning 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point I’m basically just changing things until it compiles.
It does currently, but crashes with a “pure virtual method called” segfault on close, and I’m too bad with C++ to have an inkling about why that might be.
I’d be happy to help getting this into shape, but I’m also happy if you just take it as inspiration.