Add IMAT separate view #510
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/jobs/JobTable.tsx
Outdated
| @@ -170,6 +170,24 @@ const JobTable: React.FC<{ | |||
|
|
|||
| const theme = useTheme(); | |||
|
|
|||
| if (selectedInstrument === 'IMAT') { | |||
There was a problem hiding this comment.
I know this is a draft, but I saw this while looking at dependabot.
I don't think we would want to render the IMAT image view in the JobTable Component. I think it would make more sense to create a new component and conditionally render the JobTable and IMATView (or whatever this is called) inside of JobsPage.tsx
i.e. conditionally here in JobsPage.tsx
<JobTable
selectedInstrument={selectedInstrument}
currentPage={currentPage}
handlePageChange={setCurrentPage}
asUser={asUser}
/>There was a problem hiding this comment.
Yeah that makes sense, will update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #508.
Description
Adds most recent image from NDXIMAT when viewing IMAT instead of a table.