SOAS FIHRIST Pull Requests

[ek13]

Dear Andrew,
SOAS decided to change where and how it commits its FIHRIST (and eventually other catalogue) record entries. Simon Bowie ([email protected]) maintains the SOAS GitHub -- /soas-library/fihrist-mss.
New procedure requires Peter to commit to the SOAS-Library then issue a pull request to you at /fihristorg/fihrist-mss
Erich

[andrew-morrison]

Your new procedure is fine by me. Long term, other people will have to learn to review and merge the pull requests (I've added Yasmin and Huw to the list of reviewers.)

But there are problems with the changes which mean I won't be merging this particular pull release. It contains new files without the schema declaration at the top, lack a unique manuscript ID in the xml:id attribute of the root TEI elements, contain authors with keys which don't use the "person_" format, and subjects not using the term element or a key attribute. Examples here, here, here, and here. Also the work titles don't have key attributes, so won't be included in the Works index on the web site (but that could be intentional.)

Also, it should be noted that your SOAS fork was taken from a version of the original repository back in April. That doesn't matter so much for adding and correcting SOAS records, but Peter will be missing his previous changes in his local working copy. It also means the authority files contain none of the new entries for work titles, person names or subject keywords added since by Cambridge, Oxford, Manchester and colleges. I'd suggest @SimonXIX resyncs your fork now, and regularly from now on if Peter wants to contribute to improving the authority files.

[SimonXIX]

Thanks Andrew. I'm happy to run regular syncs: that makes sense.

Peter and Erich: I've attempted to resync but been told that 'ms. 48052.xml' would be overwritten by a merge from Fihrist's upstream repository. Could you please move it elsewhere temporarily to keep it safe and let me know when you've done so? I'll then try running the merge again. Long-term, we'll need to figure out a schedule for regular syncing.

[SimonXIX]

I've now synced the changes from FIHRIST and pushed those changes to our remote fork. Both our working copy and our remote should be in sync with FIHRIST's repository (apart from our local changes).

[ek13]

Thanks. This helps greatly. Ooo. I think I failed to add you to my message from this morning's work. Will send directly. Erich Kesse Digital Library Project Officer SOAS, University of London Russell Square, London WC1H 0XG Telephone +44 (0) 20 7898 4798 https://www.soas.ac.uk/library/

…

On Mon, 8 Oct 2018 at 12:05, Simon Bowie ***@***.***> wrote: I've now synced the changes from FIHRIST and pushed those changes to our remote fork. Both our working copy and our remote should be in sync with FIHRIST's repository (apart from our local changes). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#68 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH52IyvS0rHMLn-pax-CPASKSHUqkrCQks5uizFtgaJpZM4XMe5G> .

[ahankinson]

One thing you may wish to keep in mind with this workflow is that, if you are committing records 'upstream' to the fihrist organization github from SOAS, it would be easier to do it in a separate branch rather than on 'master'. A common pattern in using GitHub is to create a specific 'branch' for submitting specific updates, and then request that they be merged.

So rather than merging 'soas:master' into 'fihristorg:master', you might request to merge 'soas:updates-to-blah' into 'fihristorg:master'.