fix: remove duplicate applySortingToTableQuery call in HasBulkActions #18998
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The applySortingToTableQuery() method was being called twice when executing bulk actions - once in getSelectedTableRecordsQuery() at line 273 and again in getSelectedTableRecords() at line 235. This caused SQL errors on SQL Server (and other databases that enforce unique columns in ORDER BY) due to duplicate ORDER BY clauses. Fixes filamentphp#18991
ismaildasci
force-pushed
the
fix/duplicate-sorting-bulk-actions
branch
from
8adae0e to
d3ac13c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where
applySortingToTableQuery()was being called twice when executing bulk actions, causing SQL errors on SQL Server.The Problem
When executing a bulk action, the
applySortingToTableQuery()method was called twice on the same query object:getSelectedTableRecordsQuery()at line 273getSelectedTableRecords()at line 235This resulted in duplicate ORDER BY clauses, which causes SQL Server (and likely other databases that enforce unique columns in ORDER BY) to throw an error:
The Fix
Remove the redundant
applySortingToTableQuery()call fromgetSelectedTableRecords()since it's already being called withingetSelectedTableRecordsQuery().Fixes #18991
Test plan
🤖 Generated with Claude Code