feat: switch from libsecp256k1 to k256

[Stebalien]

The former is deprecated in favor of the latter.

[Stebalien]

We should consider using the signature verification logic from shared in our tests. I didn't want to do that because I wanted to eventually remove it from shared but we'll get better test coverage...

Alternatively, we should port the other 3 ecrecover test vectors to the EVM. TBH, that's probably the right thing to do.

[rvagg]

Alternatively, we should port the other 3 ecrecover test vectors to the EVM

can you spell this out a bit more, I've lost the list of failing tests now that you've fixed it but I imagine it would be obvious if I could see what caused you to discover the usage bug

[Stebalien]

1. The EC recover test cases from

   builtin-actors/actors/evm/src/interpreter/precompiles/evm.rs

   Line 524 in b5e9409

   (ec_recover, "ecRecover"),

   . Test vectors in https://github.com/filecoin-project/builtin-actors/blob/b5e940909192f41e70d179e0c9627f2858e62617/actors/evm/precompile-testdata/ecRecover.json.
2. Possibly also a good idea to port

   builtin-actors/actors/evm/src/interpreter/precompiles/evm.rs

   Lines 315 to 354 in b5e9409

   	fn bn_recover() {
   	let rt = MockRuntime::default();
   	rt.in_call.replace(true);
   	let mut system = System::create(&rt).unwrap();
   	let input = &hex!(
   	"456e9aea5e197a1f1af7a3e85a3212fa4049a3ba34c2289b4c860fc0b0c64ef3" // h(ash)
   	"000000000000000000000000000000000000000000000000000000000000001c" // v (recovery byte)
   	// signature
   	"9242685bf161793cc25603c231bc2f568eb630ea16aa137d2664ac8038825608" // r
   	"4f8ae3bd7535248d0bd448298cc2e2071e56992d0774dc340c368ae950852ada" // s
   	);
   	let expected = hex!("0000000000000000000000007156526fbd7a3c72969b54f64e42c10fbb768c8a");
   	let res = ec_recover(&mut system, input, PrecompileContext::default()).unwrap();
   	assert_eq!(&res, &expected);
   	let input = &hex!(
   	"456e9aea5e197a1f1af7a3e85a3212fa4049a3ba34c2289b4c860fc0b0c64ef3" // h(ash)
   	"000000000000000000000000000000000000000000000000000000000000001c" // v (recovery byte)
   	// signature
   	"0000005bf161793cc25603c231bc2f568eb630ea16aa137d2664ac8038825608" // r
   	"4f8ae3bd7535248d0bd448298cc2e2071e56992d0774dc340c368ae950852ada" // s
   	);
   	// wrong signature
   	let res = ec_recover(&mut system, input, PrecompileContext::default()).unwrap();
   	assert!(res.is_empty());
   	let input = &hex!(
   	"456e9aea5e197a1f1af7a3e85a3212fa4049a3ba34c2289b4c860fc0b0c64ef3" // h(ash)
   	"000000000000000000000000000000000000000000000000000000000000000a" // v (recovery byte)
   	// signature
   	"0000005bf161793cc25603c231bc2f568eb630ea16aa137d2664ac8038825608" // r
   	"4f8ae3bd7535248d0bd448298cc2e2071e56992d0774dc340c368ae950852ada" // s
   	);
   	// invalid recovery byte
   	let res = ec_recover(&mut system, input, PrecompileContext::default()).unwrap();
   	assert!(res.is_empty());
   	}

   .

[Stebalien]

I attempted to switch to shared in #1676 but we'd need to add a separate "signature" feature because including "all of crypto" is too much.