Skip to content

Recyclebin improvements #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 26, 2020
Merged

Recyclebin improvements #1137

merged 9 commits into from
Jun 26, 2020

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jun 19, 2020 •
edited
Loading

Implement some of the changes suggested here #1089
Changes:

@gave92 gave92 force-pushed the recyclebin_improvements branch 2 times, most recently from ce0f8ba to 46b0db2 Compare June 19, 2020 05:55
@yaira2 yaira2 assigned lukeblevins and unassigned lukeblevins Jun 19, 2020
@yaira2 yaira2 requested a review from lukeblevins June 19, 2020 11:55
lukeblevins
lukeblevins approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gave92 gave92 marked this pull request as ready for review June 19, 2020 19:56
@ghost ghost added the needs - code review label Jun 19, 2020
@gave92 gave92 force-pushed the recyclebin_improvements branch 4 times, most recently from 0c102cb to 571e6f2 Compare June 21, 2020 20:42
@yaira2 yaira2 requested a review from tsvietOK June 23, 2020 05:14
@gave92
Updated Vanara library
4d3dc62 
Use filesystem watcher for recyclebin
Customize recyclebin contextmenu
Add confirm dialog to empty bin
Properties for recyclebin
Fix move files
Fix properties in recycle bin
@gave92 gave92 force-pushed the recyclebin_improvements branch from a3378d8 to 4d3dc62 Compare June 23, 2020 18:06
@gave92 gave92 mentioned this pull request Jun 23, 2020
Closed
tsvietOK
tsvietOK suggested changes Jun 24, 2020
View reviewed changes
tsvietOK
tsvietOK reviewed Jun 24, 2020
View reviewed changes
@tsvietOK
Copy link
Contributor

Issue #1199 is not fixed. Still getting the same exception in debug_fulltrust.txt

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Jun 24, 2020
@gave92 gave92 force-pushed the recyclebin_improvements branch from 97890b8 to 2e39a03 Compare June 24, 2020 14:49
@gave92
Copy link
Member Author

gave92 commented Jun 24, 2020 •
edited
Loading

@tsvietOK Can't reproduce that exception anymore, mind telling me on which line is thrown? Thanks!

@tsvietOK
Copy link
Contributor

I can't tell you where the exception, but that's what i get:
image

@gave92
Copy link
Member Author

gave92 commented Jun 24, 2020 •
edited
Loading

In the picture I'm seeing a "NullReferenceException", in issue #1199 it was an "InvalidCastException". Is the debug_fulltrust.txt still the same?

To get the exception line you could:

  • launch Files Dev from start menu
  • in visual studio:
    • click Debug menu
    • click Attach to process..
    • select "FilesFullTrust.exe"
  • go to recyclebin in Files Dev and get exception

If it doesn't work I can make a version with some additional debug logs.

@gave92 gave92 requested a review from tsvietOK June 24, 2020 22:56
@tsvietOK
Copy link
Contributor

@gave92
image

@gave92
Copy link
Member Author

gave92 commented Jun 25, 2020

@tsvietOK Could you confirm whether the issue you reported is still present in the latest commit? Thanks!

@tsvietOK
Copy link
Contributor

@gave92 Issue fixed, good job!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jun 25, 2020
This was linked to issues Jun 25, 2020
RecycleBin: When opening Recycle bin it appears empty. #1199
Closed
Cut/Paste deleting files to Recycle Bin #1181
Closed
@yaira2
Copy link
Member

yaira2 commented Jun 25, 2020 •
edited
Loading

@gave92 Can you resolve the merge conflicts?

@yaira2 yaira2 merged commit 6dcb360 into files-community:master Jun 26, 2020
@gave92 gave92 deleted the recyclebin_improvements branch June 26, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeblevins lukeblevins lukeblevins approved these changes

@tsvietOK tsvietOK tsvietOK approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
4 participants
@gave92 @tsvietOK @yaira2 @lukeblevins