Code Quality: Convert into await using statement or declaration #16694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
Lamparter
reviewed
Jan 17, 2025
| { | ||
| SevenZipCompressor compressor = new SevenZipCompressor() { CompressionMode = CompressionMode.Append }; | ||
| compressor.SetFormatFromExistingArchive(archiveStream); | ||
| var fileName = IO.Path.GetRelativePath(containerPath, zipDesiredName); | ||
| await compressor.CompressStreamDictionaryAsync(archiveStream, new Dictionary<string, Stream>() { { fileName, contents } }, Credentials.Password, ms); | ||
| } | ||
| using (var archiveStream = await OpenZipFileAsync(FileAccessMode.ReadWrite)) | ||
|
|
There was a problem hiding this comment.
Why the newline changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
await usingstatement or declaration #15092Steps used to test these changes