Skip to content

Feature: Display placeholder when sidebar sections are all hidden#17039

Merged
yair100 merged 2 commits intomainfrom
ya/SidebarBanner
Apr 22, 2025
Merged

Feature: Display placeholder when sidebar sections are all hidden#17039
yair100 merged 2 commits intomainfrom
ya/SidebarBanner

Conversation

@yair100
Copy link
Member

@yair100 yair100 commented Apr 10, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed the banner is displayed when all section are hidden
  2. Confirmed banner is shown when other sections are hidden and wsl section is empty
  3. Confirmed banner is hidden in compact mode

@yair100 yair100 added the ready for review Pull requests that are ready for review label Apr 10, 2025
pratyush0898

This comment was marked as spam.

@yair100 yair100 force-pushed the ya/SidebarBanner branch 2 times, most recently from 100dd21 to 825d0e1 Compare April 21, 2025 16:06
@yair100 yair100 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Apr 22, 2025
@yair100 yair100 merged commit ba4fb0f into main Apr 22, 2025
8 checks passed
@yair100 yair100 deleted the ya/SidebarBanner branch April 22, 2025 00:25
@yair100 yair100 changed the title Feature: Display banner when all sections are hidden on the sidebar Feature: Display placeholder when sidebar sections are all hidden Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Display banner when all sections are hidden on the sidebar

2 participants