Fixes an issue for which changes to Bundles are not saved

[gave92]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Cannot rename bundles  #5255
• Fixes an issue with recyclebin count mentioned by @BanCrash in Feature: Improving the recycle bin experience #1089

Validation
How did you test these changes?

• Built and ran the app

[d2dyno1]

Hmm.. Is the caching here causing Bundles not to be saved? If so, you can pass false to the constructor to disable it

[gave92]

It's sort of related to caching, I went for this solution since it leaves caching enabled when reading a setting (which is the important part).

The actual problem is the following:

Dictionary<string, List<string>> allBundles = BundlesSettings.SavedBundles;
allBundles[ParentBundleName].Remove(Path);
BundlesSettings.SavedBundles = allBundles;

allBundles and BundlesSettings.SavedBundles point to the same object (the cached setting) so when you check if the setting has changed before saving, the new value is always identical to the current value.

[yair100]

@gave92 thank you!