-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Record batch time #278
base: main
Are you sure you want to change the base?
Conversation
I'm thinking if this can become a callback |
src/refiners/foundationals/latent_diffusion/stable_diffusion_1/unet.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is gonna be useful! Maybe you can take inspiration on how the TrainingClock Callback is implemented? Let's try to pollute as little as possible the core of the Trainer
@limiteinductive do you think I should make a timer config or merge timer with clock? |
I think it makes sense to merge with Clock and extend its config. |
This piece of code helped me identify how much time is spent in the data processing stage, the forward pass, and backward pass so that I know where to optimize.
The main steps blocking this pr will be