fix: Replace runtime enum BotKind with plain object
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finesse
reviewed
Aug 3, 2023
dj-stormtrooper
changed the title
BotKind with plain object
Finesse
reviewed
Aug 3, 2023
dj-stormtrooper
commented
Aug 3, 2023
| Unknown = 'unknown', | ||
| } | ||
| export const BotKind = { | ||
| // Object is used instead of Typescript enum to avoid emitting IIFE which might be affected by further tree-shaking. |
There was a problem hiding this comment.
Put the comment here because it's maintainer-faced info, don't think we need it in the JSDoc annotation
xnerhu
previously approved these changes
Aug 3, 2023
xnerhu
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new Sergey's idea BotD API remains unchanged, only runtime under-the-hood behaviour is different