Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTER-726] Fix invalid host header #225

Merged
merged 15 commits into from
Jun 18, 2024
Merged

Conversation

TheUnderScorer
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jun 13, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
97.79% (+1.51% 🔼)
221/226
🟢 Branches
85.25% (+4.11% 🔼)
52/61
🟢 Functions
97.92% (+0.14% 🔼)
47/48
🟢 Lines
97.75% (+1.54% 🔼)
217/222
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢 proxy/utils/ip.ts 100% 100% 100% 100%

Test suite run success

96 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from d368209

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 97.78 85.24 97.91 97.74
🟢  management 95.19 69.23 94.44 95.19
🟢   github.ts 87.5 62.5 85.71 87.5 10-20,69
🟢   healthCheck.ts 100 66.66 100 100 57
🟢   rollback.ts 100 100 100 100
🟡   semver.ts 80 100 100 80 7
🟢   settings.ts 100 100 100 100
🟢   site.ts 100 80 100 100 55
🟢   storage.ts 100 100 100 100
🟢  proxy/errors 100 100 100 100
🟢   IntegrationError.ts 100 100 100 100
🟢  proxy/utils 100 97.14 100 100
🟢   cacheControl.ts 100 100 100 100
🟢   cookies.ts 100 100 100 100
🟢   errorResponse.ts 100 100 100 100
🟢   headers.ts 100 95.23 100 100 74
🟢   ip.ts 100 100 100 100
🟢   region.ts 100 100 100 100
🟢   traffic.ts 100 100 100 100

proxy/utils/headers.ts Outdated Show resolved Hide resolved
sshelomentsev
sshelomentsev previously approved these changes Jun 17, 2024
Copy link
Contributor

@necipallef necipallef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after removing request.headers.host usage we can merge

necipallef
necipallef previously approved these changes Jun 18, 2024
Copy link
Contributor

This PR will create a patch release 🚀

1.4.1 (2024-06-18)

Bug Fixes

  • don't use host header for determining request url (639602e)
  • omit cookies when sending request to CDN (c7f3783)
  • preserve query parameters for agent request (49eb9c7)
  • provide correct fpjs-proxy-forwarded-host header when using frontdoor (341094f)
  • rely only on non-spoofable x-azure-socketip for resolving client ip (7f818ca)
  • remove cookies for browser cache requests (4329da6)
  • set cookies to undefined if _iidt cookie is not present in ingress request (554b1e6)
  • simplify cookie parsing (37852fd)
  • strip port from client ip (0ccf5a2)
  • use x-azure-socketip first for resolving client ip (4e0db7b)

Build System

  • deps: bump @azure/identity from 4.0.1 to 4.2.1 (d6bad44)

@TheUnderScorer TheUnderScorer merged commit 9a0d3c3 into rc Jun 18, 2024
9 checks passed
@TheUnderScorer TheUnderScorer deleted the bugfix/INTER-726-invalid-host branch June 18, 2024 15:00
@fingerprint-dx-team
Copy link
Contributor

🎉 This PR is included in version 1.4.1-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fingerprint-dx-team
Copy link
Contributor

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants