Fix/nmpapp 1572 accessbility improve #1398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyMomot
requested review from
a team,
robinsalehjan and
Breiby
and removed request for
a team
Breiby
reviewed
Feb 4, 2025
FinniversKit/Sources/Components/Button/IconButton/IconButton.swift
Outdated
Show resolved
Hide resolved
| @@ -218,7 +218,7 @@ extension JobAdRecommendationCell: AdRecommendationConfigurable { | |||
| loadingColor = .backgroundSubtle | |||
|
|
|||
| containerView.accessibilityLabel = model?.accessibilityLabel | |||
| favoriteButton.accessibilityLabel = model?.favoriteButtonAccessibilityLabel | |||
There was a problem hiding this comment.
Is the accessibilityLabel being set somewhere else?
There was a problem hiding this comment.
Good catch, I lost it during merging
Put back it here: https://github.com/finn-no/FinniversKit/pull/1398/files#diff-9c2c5679975471f2eb787c6436339de8efe689425e440bd4e0e5a92a9e5ac503R24
Breiby
approved these changes
Feb 5, 2025
added 2 commits
February 5, 2025 10:56
|
Refactored whole favorite accessibility stuff so now it becomes a struct |
Breiby
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Poor accessibility for favourite & share buttons
What?
Improve accessibility for favourite & share buttons
Version Change
Major
UI Changes
ios-app PR