-
Notifications
You must be signed in to change notification settings - Fork 147
Replace console.log with structured logging #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 20 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
b0eb1b4
feat: add in Winston logger and replace console.logs with relevant lo…
LewisBroadhurst 3548464
feat: auto-formatting
LewisBroadhurst 4ab7b53
feat: change folder name to allow logger.js to be committed
LewisBroadhurst 09f5a9e
Fix paths for logger
LewisBroadhurst f85483a
More logging module path fixes
LewisBroadhurst 3bf39a9
feat: requirement for non ES6 import for logger
LewisBroadhurst d9d26fb
feat: remove logger from ui
LewisBroadhurst 20637b0
feat: remove logger from ui
LewisBroadhurst dca1ed4
Merge branch 'main' into structured-logging
LewisBroadhurst dccdc78
feat: fix up imports and make logger into a module
LewisBroadhurst ef3cf62
feat: add better formatting to log
LewisBroadhurst 4e443f8
feat: add better formatting to logs
LewisBroadhurst 059e76f
feat: change log filename
LewisBroadhurst a3b6b67
Merge branch 'main' into structured-logging
LewisBroadhurst b1c2381
feat: fix more imports
LewisBroadhurst c707785
feat: test...
LewisBroadhurst e6a0e51
fix: improvement to logs and fix for 'Unknown logger level: host' error
LewisBroadhurst d8b538c
fix: remove test file and fix typo
LewisBroadhurst af52a50
fix: more log import fixing
LewisBroadhurst 9c161c9
fix: linter change
LewisBroadhurst c955e73
Merge branch 'main' into structured-logging
JamieSlome 6e44a7c
fix: remove console.log from internal tooling
LewisBroadhurst fcf61a8
fix: remove logger import
LewisBroadhurst fc6a6f2
Merge branch 'structured-logging' of https://github.com/LewisBroadhur…
LewisBroadhurst 7bfae3a
test: began adding testing for git-proxy.log
LewisBroadhurst 03fbbc7
feat: ...
LewisBroadhurst 9bdaec1
feat: logging func tests
LewisBroadhurst 1a20bf1
feat: logging func tests
LewisBroadhurst f1d2f4d
Merge branch 'main' into structured-logging
LewisBroadhurst df48552
feat: combine console/winston logging
LewisBroadhurst 3f1698c
Merge branch 'structured-logging' of https://github.com/LewisBroadhur…
LewisBroadhurst a885b1b
fix: add logger line
LewisBroadhurst 94499b5
fix: test commit
LewisBroadhurst eecb957
feat: ...
LewisBroadhurst dc2672f
chore: remove test commit line
LewisBroadhurst d7a0c32
chore: remove test commit line
LewisBroadhurst 3dbf6fa
feat: alternative logger with filename
LewisBroadhurst 3b44195
fix: work out how to add filenames into logger without custom wrapper
LewisBroadhurst 8b03c6c
chore: linting
LewisBroadhurst 7ffe660
feat: merge in latest main branch and change console.logs
LewisBroadhurst 3869f4e
feat: more console.log -> logger.info changes
LewisBroadhurst 520c5a5
Merge branch 'main' into structured-logging
JamieSlome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| const { logger } = require('./src/logging/index'); | ||
| const opts = { | ||
| branches: 80, | ||
| lines: 80, | ||
| functions: 80, | ||
| statements: 80, | ||
| }; | ||
|
|
||
| console.log('nyc config: ', opts); | ||
| logger.info(`nyc config: ${opts}`); | ||
| module.exports = opts; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.