Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add https support #546 #558

Merged
merged 5 commits into from
Jun 5, 2024
Merged

feat: add https support #546 #558

merged 5 commits into from
Jun 5, 2024

Conversation

maoo
Copy link
Member

@maoo maoo commented May 10, 2024

Implements #546

Copy link

github-actions bot commented May 10, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

netlify bot commented May 10, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 7849b10
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66603b5d2d29a40008c97204

@maoo maoo mentioned this pull request May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (8fe6a58) to head (7849b10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   56.96%   57.39%   +0.43%     
==========================================
  Files          46       46              
  Lines        1566     1582      +16     
==========================================
+ Hits          892      908      +16     
  Misses        674      674              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 56.76%. Comparing base (297f7e7) to head (37fc948).

Files Patch % Lines
src/config/index.js 37.50% 10 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@maoo - can we get at least 80%? 🫶

@maoo
Copy link
Member Author

maoo commented May 10, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 56.76%. Comparing base (297f7e7) to head (37fc948).

Files Patch % Lines
src/config/index.js 37.50% 10 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@maoo - can we get at least 80%? 🫶

how does 100% sound? 😄

@maoo maoo marked this pull request as ready for review May 12, 2024 08:04
certs/cert.pem Outdated Show resolved Hide resolved
certs/key.pem Outdated Show resolved Hide resolved
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a wonderful PR, @maoo. I've left a couple of comments to help enlighten my unenlightened mind on HTTP/HTTPs. Appreciate you as ever! 👍 ❤️

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 16a04ff into main Jun 5, 2024
13 checks passed
@JamieSlome JamieSlome deleted the 546-https-support branch June 5, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants