Skip to content

refactor: code clone component #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tt-gideonaryeetey
Copy link
Contributor

@tt-gideonaryeetey tt-gideonaryeetey commented Jul 9, 2024

Closes #630

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 051c7a9
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66fd3e24c64ce000088edcb6

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (e850caf) to head (051c7a9).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

@tt-gideonaryeetey - thanks for the pull request 🎉

Are we able to include a Cypress test to ensure the stability of the new component moving forward?

@tt-gideonaryeetey
Copy link
Contributor Author

@tt-gideonaryeetey - thanks for the pull request 🎉

Are we able to include a Cypress test to ensure the stability of the new component moving forward?

Yes, we can definitely include a Cypress test. I'll start working on it

@JamieSlome
Copy link
Member

@tt-gideonaryeetey - amazing, thank you 👍

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 3370064 into finos:main Oct 2, 2024
13 checks passed
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
…e-component-to-repository-page

refactor: code clone component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code clone component to repository page ⬇️
2 participants