chore: upgrade admin dashboard ui to react 18 #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 60.23% 60.23%
=======================================
Files 47 47
Lines 1647 1647
=======================================
Hits 992 992
Misses 655 655 ☔ View full report in Codecov by Sentry. |
lwhiteley
force-pushed
the
react-upgrade
branch
from
8907390
to
3da5250
Compare
lwhiteley
changed the title
lwhiteley
force-pushed
the
react-upgrade
branch
from
ef2c143
to
ecdd7a3
Compare
lwhiteley
force-pushed
the
react-upgrade
branch
from
ecdd7a3
to
faff3a2
Compare
lwhiteley
changed the title
lwhiteley
force-pushed
the
react-upgrade
branch
from
be1d0e2
to
39789bb
Compare
|
@lwhiteley - happy for me to start reviewing? |
lwhiteley
force-pushed
the
react-upgrade
branch
from
cd2f214
to
7500dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Notes:
After an audit of the dependencies of this project, it was determined that react and a few libraries were outdated.
one of the dependencies preventing an upgrade is
react-html-parser. it has a peer dependency of react 16.A successor of the package is
html-react-parserHowever, there is no storybook setup in the project or a way to test this easily.
How can i get diff data passed to this component to test in isolation or
Can someone give steps to arrive at this view to test it in the UI to verify it works?
I also see that there are cypress tests but i dont believe this view is covered yet
old package: https://www.npmjs.com/package/react-html-parser
proposed package: https://www.npmjs.com/package/html-react-parser
TODOs:
Please test thoroughly
Let me know if i missed something