Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added pagination and search component #783

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

darkhorse-420
Copy link

@darkhorse-420 darkhorse-420 commented Nov 6, 2024

added pagination , sort and search to /Repositories and /Users

Screenshot 2024-11-15 at 11 55 29 PM
Screenshot 2024-11-15 at 11 55 48 PM
Screenshot 2024-11-16 at 12 22 05 AM

Copy link

linux-foundation-easycla bot commented Nov 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d2e5a38
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/673791b77ef15500086c5ba2

@laukik-target
Copy link
Contributor

Testing Results:

  1. This placement can it be done better? Maybe symmetric and think of a consistent design/color scheme
    image

  2. Pagination is working fine and Searching is working fine but to search, we have to type and then hit enter. Can we make it efficient by implementing search as you type, I mean "real-time search" or "instant search."

@JamieSlome
Copy link
Member

Great pull request 👍 Is there any chance we could add search on the dashboard page as well for searching pushes and commits?

@darkhorse-420
Copy link
Author

yes will do that @JamieSlome .

@darkhorse-420
Copy link
Author

alright, thanks for the suggestions @laukik-target , will incorporate the same.

@darkhorse-420
Copy link
Author

Great pull request 👍 Is there any chance we could add search on the dashboard page as well for searching pushes and commits?

what is the format of data that is expected in pushes.db? i wanted to test my code for the dashboard page.

@darkhorse-420
Copy link
Author

☝🏻Modified the UI of search bar and added real-time search.

@JamieSlome
Copy link
Member

@darkhorse-420 - we can always merge as is and follow up with another PR for dashboard searching?

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (dd5d692) to head (8cc3b0b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   63.11%   63.11%           
=======================================
  Files          47       47           
  Lines        1678     1678           
=======================================
  Hits         1059     1059           
  Misses        619      619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkhorse-420
Copy link
Author

@darkhorse-420 - we can always merge as is and follow up with another PR for dashboard searching?

okay @JamieSlome , actually when i run the dashboard page it doesnt show any data. (not sure if its an issue on my end)
i have modified the code of the dashboard page on my local to add the search and pagination component and tested with some dummy data it works fine . i havent created the PR yet because im not sure how it will work with actual data.

@darkhorse-420
Copy link
Author

Screenshot 2024-11-15 at 11 55 29 PM
Screenshot 2024-11-15 at 11 55 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants