-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove exports from package.json and adjust imports #793
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Seeing as we'd be breaking import statements, we'll make a minor bump to |
Exports makes it hard to access other paths in the project Until we arrive on stable interfaces to access other parts of git-proxy removing exports would be helpful. Import paths have been adjusted slightly for plugins and the docs for plugins due to the exports aliases being a bit different.
6aef905
to
c5d200d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 63.11% 63.11%
=======================================
Files 47 47
Lines 1678 1678
=======================================
Hits 1059 1059
Misses 619 619 ☔ View full report in Codecov by Sentry. |
Running into some blockers due to the This does break some import paths because the exports were slightly different to the actual file paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with the points raised here. exports
can be re-introduced in a later release.
Need update the plugin docs as well once this is released.
Exports makes it hard to access other paths in the project
Until we arrive on stable interfaces to access other parts of git-proxy
removing exports would be helpful.
Import paths have been adjusted slightly for plugins and the docs for
plugins due to the exports aliases being a bit different.