Skip to content

Conversation

@MauricioUyaguari
Copy link
Member

…data

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner August 4, 2025 17:49
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: 95fa46b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@finos/legend-application-studio Minor
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-pure-ide Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-marketplace-bootstrap Patch
@finos/legend-application-marketplace-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 4, 2025

CLA Not Signed

- Import guaranteeNonNullable from @finos/legend-shared
- Fix array index keys using guaranteeNonNullable
- Fix TypeScript type safety in CSV parsing methods
- Fix media feature range notation in SCSS
- Remove trailing spaces and fix formatting
- Maintain CSV importer at bottom with proper labels

Co-Authored-By: [email protected] <[email protected]>
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 8.53081% with 579 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.23%. Comparing base (c84ff80) to head (07a885e).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...tor-group/data-editor/RelationalTestDataEditor.tsx 9.20% 355 Missing ⚠️
...ate/element-editor-state/data/EmbeddedDataState.ts 6.03% 218 Missing ⚠️
...or/editor-group/data-editor/EmbeddedDataEditor.tsx 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4324      +/-   ##
==========================================
- Coverage   46.33%   46.23%   -0.10%     
==========================================
  Files        2452     2454       +2     
  Lines      437314   438529    +1215     
  Branches    18681    12944    -5737     
==========================================
+ Hits       202608   202748     +140     
- Misses     234018   235093    +1075     
  Partials      688      688              
Files with missing lines Coverage Δ
.../stores/editor/editor-state/ExternalFormatState.ts 74.57% <100.00%> (+0.21%) ⬆️
...or/editor-group/data-editor/EmbeddedDataEditor.tsx 25.49% <33.33%> (-0.07%) ⬇️
...ate/element-editor-state/data/EmbeddedDataState.ts 28.02% <6.03%> (-13.14%) ⬇️
...tor-group/data-editor/RelationalTestDataEditor.tsx 9.20% <9.20%> (ø)

... and 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant