Skip to content

Conversation

@yash0024
Copy link
Contributor

Bring RelationElementsData to pure graph and Rename FunctionStoreTestData to FunctionTestData

Summary

Bring RelationElementsData to pure graph and Rename FunctionStoreTestData to FunctionTestData

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@yash0024 yash0024 requested a review from a team as a code owner September 24, 2025 17:15
@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2025

🦋 Changeset detected

Latest commit: 106a857

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-graph Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-marketplace Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-server-lakehouse Patch
@finos/legend-server-marketplace Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-marketplace-bootstrap Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-marketplace-deployment Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 30.37543% with 204 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.49%. Comparing base (3a2a5a8) to head (106a857).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...alizationHelpers/V1_FunctionSerializationHelper.ts 13.04% 40 Missing ⚠️
...ger/protocol/pure/v1/model/data/V1_EmbeddedData.ts 20.00% 36 Missing ⚠️
...raph/src/graph/metamodel/pure/data/EmbeddedData.ts 16.66% 35 Missing ⚠️
...mation/pureGraph/from/V1_DataElementTransformer.ts 31.70% 28 Missing ⚠️
...ureGraph/to/helpers/V1_DataElementBuilderHelper.ts 18.18% 18 Missing ⚠️
...on-studio/src/stores/editor/utils/TestableUtils.ts 16.66% 15 Missing ⚠️
...nction-activator/testable/FunctionTestableState.ts 12.50% 7 Missing ⚠️
...ion/pureGraph/to/helpers/V1_DomainBuilderHelper.ts 30.00% 7 Missing ⚠️
...nsformation/pureGraph/from/V1_DomainTransformer.ts 20.00% 4 Missing ⚠️
packages/legend-graph/src/index.ts 0.00% 4 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4472      +/-   ##
==========================================
- Coverage   46.53%   46.49%   -0.04%     
==========================================
  Files        2486     2486              
  Lines      447322   447559     +237     
  Branches    19020    13227    -5793     
==========================================
- Hits       208151   208085      -66     
- Misses     238713   238775      +62     
- Partials      458      699     +241     
Files with missing lines Coverage Δ
...rmation/pureGraph/from/V1_CoreTransformerHelper.ts 100.00% <100.00%> (ø)
packages/legend-graph/src/graph/Core_HashUtils.ts 100.00% <100.00%> (ø)
...ger/action/changeDetection/DomainObserverHelper.ts 35.46% <66.66%> (ø)
...ableElements/function/test/V1_FunctionTestSuite.ts 64.70% <50.00%> (ø)
...zationHelpers/V1_DataElementSerializationHelper.ts 80.13% <96.66%> (+1.85%) ⬆️
...ageableElements/function/test/FunctionTestSuite.ts 64.70% <50.00%> (ø)
...stores/graph-modifier/DomainGraphModifierHelper.ts 61.22% <50.00%> (ø)
...eableElements/function/test/V1_FunctionTestData.ts 62.85% <33.33%> (ø)
...kageableElements/function/test/FunctionTestData.ts 63.88% <50.00%> (ø)
...nsformation/pureGraph/from/V1_DomainTransformer.ts 86.35% <20.00%> (ø)
... and 9 more

... and 284 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant