Skip to content

Conversation

@aziemchawdhary-gs
Copy link
Contributor

Pure IDE: Add basic split editor support

@aziemchawdhary-gs aziemchawdhary-gs requested a review from a team as a code owner October 8, 2025 21:46
@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2025

🦋 Changeset detected

Latest commit: f122b86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@finos/legend-application-pure-ide Patch
@finos/legend-application Patch
@finos/legend-lego Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-marketplace-bootstrap Patch
@finos/legend-application-marketplace Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-data-cube Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-product Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-marketplace-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aziemchawdhary-gs aziemchawdhary-gs marked this pull request as draft October 8, 2025 21:49
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 1368 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.54%. Comparing base (86edd91) to head (f122b86).

Files with missing lines Patch % Lines
...ation-pure-ide/src/stores/EditorSplitGroupState.ts 0.00% 512 Missing and 1 partial ⚠️
...de/src/components/editor-group/EditorGroupLeaf.tsx 0.00% 410 Missing ⚠️
...ackages/legend-lego/src/application/TabManager.tsx 0.00% 110 Missing ⚠️
...e/src/components/editor-group/EditorSplitGroup.tsx 0.00% 98 Missing ⚠️
...nd-application-pure-ide/src/stores/PureIDEStore.ts 0.00% 81 Missing ⚠️
...application-pure-ide/src/stores/FileEditorState.ts 0.00% 45 Missing ⚠️
...ges/legend-lego/src/application/TabManagerState.ts 0.00% 21 Missing ⚠️
.../src/components/editor-group/GenericFileEditor.tsx 0.00% 17 Missing ⚠️
...ide/src/components/editor-group/PureFileEditor.tsx 0.00% 17 Missing ⚠️
...re-ide/src/components/editor-group/EditorGroup.tsx 0.00% 13 Missing ⚠️
... and 8 more

❗ There is a different number of reports uploaded between BASE (86edd91) and HEAD (f122b86). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (86edd91) HEAD (f122b86)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4523       +/-   ##
===========================================
- Coverage   47.18%    2.54%   -44.65%     
===========================================
  Files        2504     2505        +1     
  Lines      451189   452419     +1230     
  Branches    18837     2536    -16301     
===========================================
- Hits       212910    11494   -201416     
- Misses     237527   439056   +201529     
- Partials      752     1869     +1117     
Files with missing lines Coverage Δ
.../src/components/side-bar/DirectoryTreeExplorer.tsx 0.00% <0.00%> (ø)
...nts/__test-utils__/BrowserEnvironmentTestUtils.tsx 0.00% <0.00%> (ø)
...nd-application-pure-ide/src/components/PureIDE.tsx 0.00% <0.00%> (ø)
...-application-pure-ide/src/components/StatusBar.tsx 0.00% <0.00%> (ø)
...-ide/src/components/editor-group/DiagramEditor.tsx 0.00% <0.00%> (ø)
.../legend-application/src/components/useCommands.tsx 0.00% <0.00%> (ø)
...ation-pure-ide/src/__lib__/LegendPureIDECommand.ts 0.00% <0.00%> (ø)
...re-ide/src/components/editor-group/EditorGroup.tsx 0.00% <0.00%> (ø)
...lication-pure-ide/src/stores/DiagramEditorState.ts 0.00% <0.00%> (ø)
.../src/components/editor-group/GenericFileEditor.tsx 0.00% <0.00%> (ø)
... and 8 more

... and 1701 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant