Skip to content

Conversation

@travisstebbins
Copy link
Contributor

  • Add tests covering tab visibility, table functionality, checkbox interactions
  • Add tests for approve/deny modal behaviors and URL navigation
  • Add test for data product details modal
  • All 10 test scenarios pass successfully
  • Includes proper mocking and async test patterns

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

- Add tests covering tab visibility, table functionality, checkbox interactions
- Add tests for approve/deny modal behaviors and URL navigation
- Add test for data product details modal
- All 10 test scenarios pass successfully
- Includes proper mocking and async test patterns

Co-Authored-By: [email protected] <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

🦋 Changeset detected

Latest commit: 4d89468

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@finos/legend-application-marketplace Patch
@finos/legend-application-marketplace-bootstrap Patch
@finos/legend-application-marketplace-deployment Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-vscode-extension-dependencies Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 20, 2025

CLA Not Signed

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.74%. Comparing base (290834a) to head (4d89468).

Files with missing lines Patch % Lines
...es/__test-utils__/TEST_DATA__LakehouseContracts.ts 0.00% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
- Coverage   46.94%   46.74%   -0.21%     
==========================================
  Files        2519     2520       +1     
  Lines      455290   455305      +15     
  Branches    12765    19479    +6714     
==========================================
- Hits       213753   212849     -904     
- Misses     241076   241384     +308     
- Partials      461     1072     +611     
Files with missing lines Coverage Δ
...es/__test-utils__/TEST_DATA__LakehouseContracts.ts 0.00% <0.00%> (ø)

... and 596 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant