Skip to content

Conversation

@gs-gunjan
Copy link
Contributor

@gs-gunjan gs-gunjan commented Oct 24, 2025

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@gs-gunjan gs-gunjan requested a review from a team as a code owner October 24, 2025 08:00
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: f3f6574

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@finos/legend-application-marketplace Patch
@finos/legend-application-marketplace-bootstrap Patch
@finos/legend-application-marketplace-deployment Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-vscode-extension-dependencies Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 10.12658% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.94%. Comparing base (7ab2dde) to head (f3f6574).

Files with missing lines Patch % Lines
...ce/src/__lib__/LegendMarketplaceTelemetryHelper.ts 9.52% 57 Missing ⚠️
...s/lakehouse/LegendMarketplaceProductViewerStore.ts 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4577      +/-   ##
==========================================
- Coverage   47.06%   46.94%   -0.12%     
==========================================
  Files        2524     2524              
  Lines      456101   456180      +79     
  Branches    13770    12787     -983     
==========================================
- Hits       214669   214163     -506     
- Misses     240968   241553     +585     
  Partials      464      464              
Files with missing lines Coverage Δ
...rketplace/src/__lib__/LegendMarketplaceAppEvent.ts 100.00% <100.00%> (ø)
...s/lakehouse/LegendMarketplaceProductViewerStore.ts 40.62% <0.00%> (-0.79%) ⬇️
...ce/src/__lib__/LegendMarketplaceTelemetryHelper.ts 39.17% <9.52%> (-7.45%) ⬇️

... and 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sourceData: object,
error: string | undefined,
): void {
const telemetryData =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets log the info we log for power bi as well.
data product, apg, ap, for origin lets make it an object with adhoc and sdlc as subtype with the gav for sdlc. we should use that same origin for power bi as well. they could move to support adhoc in the future

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know we have that infor in sourceData but we should put it in the same shape as power bi so we can analyze it similarly .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants