Skip to content

ci(ai): Only run mock responses check on AI PRs#9335

Merged
dlarocque merged 1 commit intomainfrom
dl/mock-response-check
Jan 16, 2026
Merged

ci(ai): Only run mock responses check on AI PRs#9335
dlarocque merged 1 commit intomainfrom
dl/mock-response-check

Conversation

@dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Oct 21, 2025

When the check-version job in the .github/workflows/check-vertexai-responses.yml workflow fails, the job comments a warning on all PRs, even if they are unrelated to Firebase AI Logic. This is distracting for SDK developers who have no control over the version of the Firebase AI mock responses. I think this job should only add a comment to PRs that make changes to packages/ai.

@dlarocque dlarocque requested a review from a team as a code owner October 21, 2025 14:24
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: e648573

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Collaborator

@google-oss-bot
Copy link
Collaborator

Size Analysis Report 1

Affected Products

No changes between base commit (22e0a1a) and merge commit (3b30d89).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fBigvLGJdg.html

@dlarocque dlarocque merged commit 58ddd6e into main Jan 16, 2026
37 checks passed
@dlarocque dlarocque deleted the dl/mock-response-check branch January 16, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments